Fix Internal Server Error from OC\Server::getL10NFactory() when app navigation is enabled#953
Conversation
930d35d to
d42c920
Compare
e4c1421 to
11e7bdd
Compare
Signed-off-by: Niko M <nikolay.moskvin@gmail.com>
Signed-off-by: Niko M <nikolay.moskvin@gmail.com>
11e7bdd to
fc9aa5a
Compare
|
Hello there, We hope that the review process is going smooth and is helpful for you. We want to ensure your pull request is reviewed to your satisfaction. If you have a moment, our community management team would very much appreciate your feedback on your experience with this PR review process. Your feedback is valuable to us as we continuously strive to improve our community developer experience. Please take a moment to complete our short survey by clicking on the following link: https://cloud.nextcloud.com/apps/forms/s/i9Ago4EQRZ7TWxjfmeEpPkf6 Thank you for contributing to Nextcloud and we hope to hear from you soon! (If you believe you should not receive this message, you can add yourself to the blocklist.) |
Signed-off-by: Carl Schwan <carl@carlschwan.eu>
be66ae5 to
146a7f6
Compare
CarlSchwan
left a comment
CarlSchwan
left a comment
There was a problem hiding this comment.
Thanks, technically already fixed on master but I prefer your solution
2 participants
Fixes an Internal Server Error (HTTP 500) on Nextcloud 34 when the FullTextSearch
navigation entry is enabled. The crash came from a static service-container lookup
(
OCP\Server::get(...)/OC\Server::getL10NFactory()) performed while building thenavigation entry, which is unsafe during boot.
Root cause
lib/AppInfo/Application.phpresolved the L10N factory and URL generator via thestatic container inside
fullTextSearchNavigation(). That closure runs only when theapp_navigationconfig flag is on, so the bug stays hidden on default installs but500s as soon as navigation is enabled.
How to verify
occ app:enable fulltextsearch && occ config:app:set fulltextsearch app_navigation --value=1🤖 AI (if applicable)
Related Links